fix(pipelines): cross-stack step dependencies have wrong name #23594
Conversation
We used to immediately recurse into the dependencies of a Step, and add a new Node for them to the current Graph if they didn't exist yet. This was originally written like this to support `inputs` for the `ShellSteps`, which would automatically add in any necessary Nodes into the same Graph as necessary without explicitly adding them. However, it would also have the effect that Steps which **would have** been added to the Graph would be parented incorrectly (they would be eagerly added to the wrong parent). Do this in two stages now: first try to resolve all step dependencies between things that are added to the graph, then create new Nodes for missing Step dependencies later. Fixes #21843.
|
|
github-actions
bot
added
bug
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
| public first() { | ||
| const nodes = new Set(this.nodes); | ||
| const sorted = this.nodes[0].rootGraph.sortedLeaves(); | ||
| for (const tranche of sorted) { |
There was a problem hiding this comment.
[tangent][non-blocking] An unexpected word: tranche: portion.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
3 participants
We used to immediately recurse into the dependencies of a Step, and add a new Node for them to the current Graph if they didn't exist yet.
This was originally written like this to support
inputsfor theShellSteps, which would automatically add in any necessary Nodes into the same Graph as necessary without explicitly adding them.However, it would also have the effect that Steps which would have been added to the Graph would be parented incorrectly (they would be eagerly added to the wrong parent).
Do this in two stages now: first try to resolve all step dependencies between things that are added to the graph, then create new Nodes for missing Step dependencies later.
Fixes #21843.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license